feat(sign): tvOS + watchOS-aware App Store signing#2
Open
proggeramlug wants to merge 4 commits into
Open
Conversation
perry-ship treated every non-macOS sign job as iOS, so tvOS bundles were packaged + uploaded (altool --type ios) against iOS validation rules and rejected. Add BuildTarget::TvosSign / WatchosSign, advertise tvos-sign / watchos-sign capabilities, route them through the iOS sign path for the shared steps (provisioning embed, codesign, .ipa) but SKIP the iOS-icon actool mangling, and parameterize the App Store upload --type (tvos for tvOS). watchOS upload type left as ios placeholder pending confirmation.
tvOS uploads were validated as tvOS but rejected for: CFBundlePackageType (now forced to APPL), missing CFBundleIcons.CFBundlePrimaryIcon (now a tvOS Brand Assets app icon via actool --platform appletvos), and an unsupported SDK (now appletvos DT/SDK values via query_tvos_sdk_info, overwriting the cross-compiled iphoneos DT keys). TvosSign path only; iOS untouched.
actool needs: 2-layer imagestacks (App Icon + App Icon - App Store),
--app-icon = brandassets bundle name 'App Icon & Top Shelf Image' (not
'App Icon'), --target-device tv, and a pre-existing output dir. This
emits CFBundleIcons.CFBundlePrimaryIcon + TVTopShelfImage.{Primary,
PrimaryImageWide}. Also add UIRequiredDeviceCapabilities=[arm64].
Assets.car generation still needs the tvOS simulator runtime in the VM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perry-ship treated every non-macOS sign job as iOS — tvOS bundles were packaged + uploaded with
altool --type ios, so App Store Connect validated them against iOS rules and rejected them (CFBundleIcons/CFBundlePackageType/UIRequiredDeviceCapabilities errors).This adds
BuildTarget::TvosSign/WatchosSign, advertisestvos-sign/watchos-signcapabilities, routes them through the iOS sign path for the shared steps (provisioning embed, codesign, .ipa creation) but skips the iOS-iconactoolmangling, and parameterizes the App Store upload--type(tvosfor tvOS). Pairs with builder-linux#4 (emit needs_finishing=tvos/watchos) so the hub routes atvos-signjob here.watchOS upload
--typeleft asiosplaceholder pending confirmation (TODO in code).