Skip to content

Add export selectors on ERC20, ERC721 & ERC165#279

Merged
maxnorm merged 4 commits intoPerfect-Abstractions:mainfrom
maxnorm:add-export-selectors
Feb 26, 2026
Merged

Add export selectors on ERC20, ERC721 & ERC165#279
maxnorm merged 4 commits intoPerfect-Abstractions:mainfrom
maxnorm:add-export-selectors

Conversation

@maxnorm
Copy link
Collaborator

@maxnorm maxnorm commented Feb 26, 2026

Summary

Make sure the refactored ERCs declare the exportSelectors function on facet to be compliant with the new Facet-Based Diamond (EIP-8153)

Changes Made

  • add on all erc20 facets
  • add on all erc721 facets
  • add on erc165 facet

Checklist

Before submitting this PR, please ensure:

  • Code follows the Solidity feature ban - No inheritance, constructors, modifiers, public/private variables, external library functions, using for directives, or selfdestruct

  • Code follows Design Principles - Readable, uses diamond storage, favors composition over inheritance

  • Code matches the codebase style - Consistent formatting, documentation, and patterns (e.g. ERC20Facet.sol)

  • Code is formatted with forge fmt

  • Existing tests pass - Run tests to be sure existing tests pass.

  • New tests are optional - If you don't provide tests for new functionality or changes then please create a new issue so this can be assigned to someone.

  • All tests pass - Run forge test and ensure everything works

  • Documentation updated - If applicable, update relevant documentation

Make sure to follow the contributing guidelines.

Additional Notes

@netlify
Copy link

netlify bot commented Feb 26, 2026

👷 Deploy request for compose-diamonds pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 665189e

@maxnorm maxnorm merged commit e06686b into Perfect-Abstractions:main Feb 26, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant