PBS-37 feature: Combine binlog_server with minimysql_server into a single executable (part 2)#158
Merged
percona-ysorokin merged 1 commit intoJul 3, 2026
Conversation
…ngle executable (part 2) https://perconadev.atlassian.net/browse/PBS-37 Global refactoring in the main "binlog_server" top-level code ('app.cpp'): - Created an abstract interface for program execution modes ('operations::basic_operation'). - Logic of individual commands (fetch/pull, list, search_by_timestamp, search_by_gtid_set, purge_binlogs, and version) put into separate classes. - Created 'operations::operation_factory' class that auto-registers all concrete 'basic_operation' derived classes and simplifies construction by operation mode name. - A set of functions used to log info from various PBS entities (config sections, storage, reader_context, connection, etc.) put into a separate file 'operations/logger_helpers.hpp' - 'binsrv::operation_mode_type' moved into 'operations::mode_type' - A set of functions used to generate ROTATE / FORMAT_DESCRIPTION / PREVIOUS_GTIDS_LOG events in the rewrite mode put into a separate file 'operations/event_generation_helpers.hpp'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PBS-37
Global refactoring in the main "binlog_server" top-level code ('app.cpp'):