PBS-37 feature: Combine binlog_server with minimysql_server into a single executable (part 1)#157
Merged
percona-ysorokin merged 1 commit intoJul 1, 2026
Conversation
…ngle executable (part 1) https://perconadev.atlassian.net/browse/PBS-37 Refactored 'minimysql_server' code: * Extracted frame-based network operations into 'minimysql/network_io_operations.hpp' * Extracted main MySQL protocol logic into 'minimysql/network_service.hpp' - Extracted sample binlog message data into 'minimysql/sample_event_collection.hpp' Where possible we now use 'boost/asio/ts/netfwd.hpp' for boost::asio forward declarations. Reworked the way how we suppress known false-positive warnings - we now always use '#pragma GCC diagnostic ignored' for individual headers instead of setting a '-Wno-error=...' flag on a whole compilation unit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PBS-37
Refactored 'minimysql_server' code:
Where possible we now use 'boost/asio/ts/netfwd.hpp' for boost::asio forward declarations.
Reworked the way how we suppress known false-positive warnings - we now always use '#pragma GCC diagnostic ignored' for individual headers instead of setting a '-Wno-error=...' flag on a whole compilation unit.