Conversation
|
I do like the idea of making it easier ... I think we also need some instructions and a better sample project (TIER is super dated). |
| * Register multiple extensions through a map | ||
| * @param extensions Map containing all of the ScimResources and the accompanying Extensions | ||
| */ | ||
| public static void registerExtensions(Map<Class<? extends ScimResource>, Collection<Class<? extends ScimExtension>>> extensions) { |
There was a problem hiding this comment.
This method signature is a bit awkward ... the user is going to work just as hard (or harder) wrapping up the Map as you are unwrapping it. Might I suggest that we change the signature of the method on line 24 to:
public static void registerExtension(Class<? extends ScimResource> rClass, Class<? extends ScimExtension>... eClass)
And that we eliminate this more complex method. This would require one line of code for each resource class which I think is reasonable.
|
Talking this through a bit with @chrisharm we realized that since we're suggesting a single method and it's got such simple code, perhaps this would better be effected directly in |
chrisharm
left a comment
chrisharm
left a comment
There was a problem hiding this comment.
Let's move these methods to the ScimExtentionRegistry
|
@chrisharm it should be just one method ... I still think we need to scrap the one that consumes a |
3 participants
Make it easier to other projects to register a ScimExtension without needing to know the internals of how the ScimRegistry works.