Move segmented restart functions to PEcAn.SIPNET#4008
Open
infotroph wants to merge 7 commits into
Open
Conversation
Member
infotroph
commented
May 22, 2026
infotroph
commented
- Relocates write_segmented_configs.SIPNET for use without needing to source it in separately
- Adds tests
- Fixes a buglet from dropping dimension when ensemble.samples contains only one trait
infotroph
added a commit
to ccmmf/workflows
that referenced
this pull request
May 22, 2026
divine7022
approved these changes
May 26, 2026
Member
divine7022
left a comment
divine7022
left a comment
There was a problem hiding this comment.
LGTM!, couple of nice to have test
but none are blockers
| @@ -0,0 +1,100 @@ | |||
| test_that("write_segmented_configs", { | |||
Member
There was a problem hiding this comment.
few this here
1 ) ryt now test only hits CSV path in segment_dataframe, but event_json fallback case is still not covered
so could be a second test_that block that omits crop_changes and provides an event_json json ?
2 ) zit worth having a test to varify RESTART_IN / RESTART_OUT chain inside the per segment sipnet.in files ? since the chain is whole point of segmented restarts, tiny check that segment 2's sipnet.in references segment 1's restart.out (and so on) could help lock in the core behaviour
up to you whether these go in this PR or followup. either is fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.