Fix Issue #13: Prevent PGEX file corruption due to insufficient disk …#49
Open
traybug23 wants to merge 1 commit intoPathVisio:mainfrom
Open
Fix Issue #13: Prevent PGEX file corruption due to insufficient disk …#49traybug23 wants to merge 1 commit intoPathVisio:mainfrom
traybug23 wants to merge 1 commit intoPathVisio:mainfrom
Conversation
…ent disk space - Added DiskSpaceValidator utility class to check available disk space - Modified DBConnDerby to validate space before creating GDB/GEX files - Added comprehensive unit tests for disk space validation - Uses conservative 10MB safety margin to prevent edge cases - Provides user-friendly error dialog when disk space is insufficient for student computers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds disk space validation before attempting to create new database files. It shows an user friendly error message instead of failing silently
Changes Made:
New utility class: DiskSpaceValidator
i - It checks available disk space on the target partition
ii - Also, it includes 10 MB safety margin to prevent any edge cases
iii - It provides human-readable space information for error messags.
Modified DBConnDerby.java
i - A disk space check was added before creating GDB/GEX files.
ii -It shows user friendly error dialog when space is insufficient.
iii - It usesconservative size estimates like 100 MB for GDB and 50 MB for GEX.
DiskValidatorTest to check test conditions for the DiskSpaceValidaor
i - It tests normal as well as some edge cases.
ii - Tests safety margin handling, null handling and non existent file handling
Testing Results:
All unit tests pass:
Time: 0.069
OK (7 tests)
Manually tested on Windows with low disk space scenarios.
Best Regards,
Snehashree Prusty. (traybug23)
@mkutmon