Skip to content

Fix Cryogenesis disabling flat damage from other sources when using Ele Hit #9694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Mar 24, 2026
Merged

Fix Cryogenesis disabling flat damage from other sources when using Ele Hit #9694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Modules/CalcOffence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3068,16 +3068,20 @@ function calcs.offence(env, actor, activeSkill)
elseif skillModList:Flag(cfg, "AllAddedDamageAsCold") then
addedDamageRedirectType = "Cold"
end
if addedDamageRedirectType and activeSkill.activeEffect.grantedEffect.name ~= "Elemental Hit" then
if addedDamageRedirectType then
for _, damageType in ipairs(dmgTypeList) do
if damageType ~= addedDamageRedirectType then
for _, value in ipairs(skillModList:Tabulate("BASE", cfg, damageType.."Min")) do
local mod = value.mod
if not value.mod.source:match("ElementalHit") then
local mod = value.mod
skillModList:ConvertMod(damageType.."Min", addedDamageRedirectType.."Min", "BASE", mod.value, mod.source, mod.flags, mod.keywordFlags, { type = "Cryogenesis Added Damage" }, unpack(mod))
end
end
for _, value in ipairs(skillModList:Tabulate("BASE", cfg, damageType.."Max")) do
local mod = value.mod
if not value.mod.source:match("ElementalHit") then
local mod = value.mod
skillModList:ConvertMod(damageType.."Max", addedDamageRedirectType.."Max", "BASE", mod.value, mod.source, mod.flags, mod.keywordFlags, { type = "Cryogenesis Added Damage" }, unpack(mod))
end
end
end
end
Expand Down
Loading