Support Sorcery Ward aegis calculation#1927
Closed
unrealdreamz wants to merge 1 commit into
Closed
Conversation
Contributor
|
Does not correctly use a different guard type and have correct breakdowns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #280
Adds calculation support for Sorcery Ward's barrier value from armour and evasion, including Sorcery Ward effect scaling and the all-damage barrier variant.
Root Cause
The exported Sorcery Ward skill data already includes
aegis_unique_shield_max_value_from_%_armour_evasion = 30, butSkillStatMaphad no mapping for that stat. As a result, the granted Sorcery Ward skill could exist without producing an aegis pool for defence/EHP calculations. The related Sorcery Ward effect and all-damage barrier passive lines also were not parsed.Fix
Sorcery Ward's Barrier can also take Physical and Chaos Damage from Hitsas the condition that switches the barrier from elemental-only aegis to shared aegis.Validation
Commands run locally:
Tooling unavailable in this checkout/host, so the targeted Busted spec and Docker suite could not be executed locally:
Risk / Rollback
Low-to-moderate risk. The new stat mapping is scoped to Sorcery Ward's exported aegis stat and the new parser entries are exact Sorcery Ward lines. If the aegis model needs adjustment, rollback is just the three touched files:
src/Data/SkillStatMap.lua,src/Modules/ModParser.lua, andspec/System/TestDefence_spec.lua.