Scale Vile Effusion by active Chaos DoT debuffs#1926
Open
unrealdreamz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #564.
Dark Effigy's hidden Vile Effusion skill now scales from the number of active Chaos damage over time debuffs that the current build can maintain on the enemy.
Root Cause
Vile Effusionis exported withProjectilesNumberModifiersNotAppliedand a staticnumber_of_additional_projectiles = 100placeholder. The generic projectile path can display that static value, but it does not encode the actual mechanic from the skill text: one projectile/DPS instance per Chaos DoT debuff on the target, with normal projectile-count modifiers ignored.That left Contagion, Essence Drain, Decaying Hex-supported curses, and Poison unable to change Dark Effigy's calculated DPS.
Fix
Vile Effusion; generic projectile modifiers remain ignored as the skill text requires.Validation
gh pr list --search "#564"-> no PRs foundgh pr list --search "Dark Effigy"-> only historical merged PRs Add support for Totems #1188 and Update gem changes from 0.1.1f #836gh pr list --search "Vile Effusion"-> only historical merged PR Update gem changes from 0.1.1f #836PASS lua compile src/Modules/CalcOffence.luaPASS lua compile spec/System/TestSkills_spec.luagit diff --checkpassed.git show --check --stat --oneline --no-renames HEADpassed.Local Busted/Docker validation was not run because this Windows checkout does not currently have
lua,luajit,busted,docker, ordocker-composeon PATH.Risk / Rollback
Risk is limited to the hidden Vile Effusion skill path. The change does not alter generic projectile-count math, generic totem logic, or other Chaos DoT skill damage.
Rollback is the single commit on this branch.