Fix Pounce support socket counting#1924
Closed
unrealdreamz wants to merge 1 commit into
Closed
Conversation
Contributor
|
Not needed anymore. Overcomplicated fix and handled by 4ec71b3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1672
Stop active-skill internal support effects from being counted as socketed support gems when validating the five-support socket limit.
Root Cause
Pounce is an active skill gem that also exports an internal support effect. During setup, socket-limit validation counted any gem instance with
supportEffect, so Pounce itself was counted as one support before the five actual socketed supports were counted. A legal Pounce setup with five support gems therefore appeared to have six supports and produced the "too many gems" warning.Fix
Validation
gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state all --search "#1672" --json number,title,state,url,headRefName,author --limit 20->[]gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state all --search "Pounce too many gems" --json number,title,state,url,headRefName,author --limit 20->[]gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state all --search "support gems socket limit" --json number,title,state,url,headRefName,author --limit 20->[]git diff --check-> passedgit diff --cached --check-> passedgit show --check --oneline --no-renames HEAD-> passedspec/System/TestSkills_spec.lua-> passedsrc/Modules/CalcSetup.lua-> blocked by a pre-existing upstream Lupa parse failure at line 970 (attempt to assign to const variable 'slot'); confirmed the same failure onupstream/devbefore this change.lua,luajit,busted,docker, anddocker-composeare not installed on this Windows PATH, so I could not run the Busted suite locally.Risk / Rollback
Risk is limited to socketed support-gem counting and support-color requirement totals. Item-granted/internal support effects should not consume sockets, while actual support gems still do. Rollback is the single commit on this branch.