Fix Queen of the Forest movement speed suppression#1921
Closed
unrealdreamz wants to merge 1 commit into
Closed
Conversation
Contributor
|
Overcomplicates the solution and does not adhere to existing mod formats |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #493.
Queen of the Forest now:
Root Cause
The Queen of the Forest movement-speed lines were present in unique data, but
ModCache.luashowed them as unparsed (nil). As a result, the evasion-scaling value and the suppression line never reached the calc layer.Movement speed was then calculated through the ordinary aggregate
MovementSpeedpath, so movement speed from boots, jewels, and passive sources still applied even though Queen of the Forest should suppress those sources.Fix
MovementSpeedmodifiers explicitly tagged withCondition:Sprinting.Validation
Passed:
Passed Lua syntax checks for touched Lua files with
lupa:Not run locally:
Reason: this machine does not have
lua,luajit,busted,docker,docker-compose, ordocker composeavailable on PATH; each command returned "not recognized" in PowerShell. The regression spec is included for CI.Risk / Rollback
Risk is limited to movement-speed calculations when the new suppression flag is present, plus the newly parsed Queen of the Forest movement-speed value. Ordinary movement-speed calculations continue using the existing path.
Rollback is straightforward: revert this commit to restore the previous parser cache and movement-speed calculation behavior.