Scale Force of Will by missing mana#1919
Closed
unrealdreamz wants to merge 1 commit into
Closed
Conversation
Contributor
|
Bug with the game, not PoB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #258
Summary
Root Cause
The modifier parser recognized
20% increased Effect of Arcane Surge on youand leftper ten percent missing Manaas unparsed trailing text inModCache.lua. That made Force of Will contribute a flat 20% Arcane Surge effect regardless of current mana.Fix
increased effect of arcane surge on you per ten percent missing mana.Multiplier:MissingManaPercentagebeside the existing clampedMultiplier:CurrentManaPercentageconfig value.div = 10, so it uses full ten-percent chunks through the existing multiplier semantics.TestItemMods_spec.lua.Validation
gh auth status-> authenticated asunrealdreamz.git diff --check-> passed; Git only reported existing Windows LF-to-CRLF checkout warnings.git diff --cached --check-> passed; Git only reported existing Windows LF-to-CRLF checkout warnings.git show --check --stat --oneline --no-renames HEAD-> passed.lua,luajit,busted,docker, ordocker-composeon PATH.Risk / Rollback
Risk is limited to modifiers that explicitly use the new missing-mana multiplier and to the existing Current Mana % config path. Rollback is the single commit if CI finds a parser/cache mismatch.