Recognize Ngamahu's Chosen Rage source#1917
Closed
unrealdreamz wants to merge 2 commits into
Closed
Conversation
d354f94 to
692c7dd
Compare
3 tasks
Contributor
|
This does not work correctly and charm specific mods need to be handled in a different way for this rage mod to work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Grants up to your maximum Rage on useas a Rage-enabling modifier.Refs #387
Root Cause
The Rage calculation intentionally requires a recognised Rage source before configured Rage stacks are applied. That invariant is important because otherwise a stale or manually-entered Rage value could silently grant impossible attack damage.
The later #387 reproduction uses Ngamahu's Chosen. Its unique modifier,
Grants up to your maximum Rage on use, was not recognised by the modifier parser, so the build did not getCondition:CanGainRage; configured Rage then stayed inactive even though the item is a valid Rage source.Fix
Grants up to your maximum Rage on usethat emitsCondition:CanGainRage.Validation
gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S '387 rage configured CanGainRage Ngamahu' --json number,title,headRefName,author,url --jq '.'->[]before PR creationgit diff --check-> passedgit diff --cached --check-> passed before commit/amendgit show --check --stat --oneline HEAD-> passedwhere/Get-Command lua-> not found on PATHwhere/Get-Command luajit-> not found on PATHwhere/Get-Command busted-> not found on PATHdocker --version/docker-compose --version-> not found on PATHTargeted Busted coverage was added in
spec/System/TestSkills_spec.lua, but I could not execute it locally because this checkout does not have Lua/LuaJIT/Busted or Docker available on PATH.Risk / Rollback
Risk is narrow: one exact Rage-source parser line plus two tests. The core Rage calculation and config semantics are unchanged.
Rollback is the single commit on this branch.