Keep corrupted gem requirements at base level#1915
Closed
unrealdreamz wants to merge 1 commit into
Closed
Conversation
Contributor
|
Will be handled in this PR #1743 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1738.
Keeps imported level-corrupted gems using their effective corrupted level for skill calculations, while using the uncorrupted gem level for level/attribute requirements.
Root Cause
Character import folded
Levels from Corruptiondirectly intogemInstance.level.SkillsTabClass:ProcessSocketGroup()then used that same effective level to computereqLevel,reqStr,reqDex, andreqInt, so a +1/-1 corrupted gem incorrectly changed its requirements.Fix
requirementGemLevelwhen a level corruption is present.requirementGemLevelwhen present, falling back to the effective gem level for normal gems.Validation
Local, non-GUI validation only:
I did not run Busted locally because this Windows checkout does not have Lua/LuaJIT/Busted on PATH. I also avoided Docker/GUI validation so no visible command windows or heavy processes were launched.
Risk / Rollback
Moderate-low risk. Normal gems continue to use their effective gem level for requirements. Only imported/saved gems with
requirementGemLeveltake the alternate path, and manual edits clear it. Rollback is this commit.