Stop Flame Breath cooldown from capping channel speed#1912
Open
unrealdreamz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1673
Fixes #1706
Makes Flame Breath use its channel hit rate for speed/DPS instead of being capped to one use per 10-second cooldown.
Root Cause
Flame Breath already has the correct attack-speed data: its 700% attack speed multiplier produces the intended 8x base weapon rate. The calculation then applies the generic cooldown cap:
Because Flame Breath has a 10-second cooldown, that clamps the final skill speed to
0.1/s, so attack speed and Rapid Attacks affect the intermediate value but not the displayed DPS.The skill data also already contains
channelled_skill_do_not_go_on_cooldown_on_finishing_channel, but that stat was not mapped to any internal behavior.Fix
channelled_skill_do_not_go_on_cooldown_on_finishing_channelto a skill flag.100% increased attack speedscales both speed and DPS instead of leaving them clamped at the cooldown rate.Validation
gh pr list --repo PathOfBuildingCommunity/PathOfBuilding-PoE2 --state open -S 'Flame Breath attack speed cooldown' --json number,title,headRefName,author,url --jq '.'->[]git diff --check-> passedgit diff --cached --check-> passedgit show --check --stat --oneline HEAD-> passedlua,luajit, andbustedare not installed on this machine, so the included regression is left for CI's Docker/Busted path.Risk / Rollback
Low-to-moderate risk. The calculation change is generic, but only skills that emit the new
CooldownDoesNotLimitSkillSpeedflag bypass the cooldown cap. At present this is driven by the explicit channel stat used by Flame Breath. Rollback is reverting this commit, which restores the previous cooldown-clamped behavior.