Fix Inhibitor charge consumption benefits#1905
Closed
unrealdreamz wants to merge 1 commit into
Closed
Conversation
Contributor
|
Fixed by me on dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
CannotConsumeChargessuppress charge-consumption benefits, fixing Inhibitor + Barrage repeat scaling from Frenzy charges.Fixes #1036
Root Cause
Inhibitor correctly adds
SkillType.CannotConsumeChargesto supported skills, but charge-consumption benefit mods are still emitted when the supported skill is built. For Barrage, the global Barrage buff keeps aBarrageRepeatsmodifier scaled byRemovableFrenzyCharge, so Lightning Spear still receives extra Barrage repeats even though Inhibitor prevents Barrage from consuming charges in game.Fix
SkillType.CannotConsumeCharges.FrenzyCharge/PowerCharge/EnduranceCharge, not removable charge multipliers.Validation
Local validation run:
I did not run Docker/Busted locally because the available full test runner is container-based and I was avoiding external test containers/windows during this session.
Risk / Rollback
Risk is limited to skills/support setups that explicitly gain
CannotConsumeCharges. The removal predicate is narrow: only removable-charge multiplier/threshold mods are filtered. Ordinary charge-count scaling is left alone. Rollback is the single commit if a supported skill is found whereCannotConsumeChargesshould still allow a removable-charge benefit.