Fix exporter loading of old GGPK data#1886
Open
unrealdreamz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1556
Summary
Data/Balance/...files and older pre-0.4.0Data/...files.SaveDatSpechelper for source switching and shutdown.Root Cause
Two exporter paths were brittle for older GGPK data:
AddDat64Filesonly looked for cached files under the newerData/Balancelayout, so older extracted data underDatawas reported missing.LoadDatSourceassignedself.datSource = valuebefore saving, then wrote the previously loadedself.datSpecsto the newly selected source's spec path. That could overwrite the spec the user was trying to load.Fix
DAT lookup now tries the exact requested path first, then the legacy
Data/path forData/Balance/entries. Source switching now saves the previous source's spec before assigning and loading the new source.Validation
git diff --check— pass, exit code 0.Risk/Rollback
Low exporter-only risk. Current cached data remains preferred because the new path is tried first; the legacy path is only a fallback. Rollback is isolated to exporter source/spec loading and cached DAT lookup.