Add dynamic attribute passive node option support for 'instead grant' mods aka Pathfinder's Traveller's Wisdom notable.#1870
Open
Devlin1991 wants to merge 4 commits into
Conversation
… mods Parse 'Attribute Passive Skills can instead grant <stat>' from passive nodes, equipped items, and custom config modifiers. Discovered options populate the Choose Attribute popup and hotkeys 4-9. Overrides save and load by stat string and auto-revert to the node default state when their source is removed. Supports right-click cycling and last-used allocation. Updated Choose Attribute popup formatting with new feature. Signed-off-by: Andrew Devlin <devlin1991@googlemail.com>
…overrides from character data. Alternative attribute node sprite now matches in-game icon. Signed-off-by: Andrew Devlin <devlin1991@googlemail.com>
Wires77
reviewed
May 17, 2026
| self.build.spec:ReplaceNode(node, self.build.spec.hashOverrides[id]) | ||
| end | ||
| elseif nodeInfo.stats and nodeInfo.stats[1] then | ||
| local stat = nodeInfo.stats[1]:gsub("%[([^%]|]*)%|?[^%]]*%]", "%1"):lower() |
Member
There was a problem hiding this comment.
We already have escapeGGGString for this, use that instead
| local attributeOverride = { elem = "AttributeOverride", attrib = { strNodes = table.concat(strList, ","), dexNodes = table.concat(dexList, ","), intNodes = table.concat(intList, ",") } } | ||
| local attrib = { | ||
| strnodes = table.concat(standard[1], ","), | ||
| dexnodes = table.concat(standard[2], ","), |
Member
There was a problem hiding this comment.
Changing these instances back to dexNodes will make the spellchecker happy again
Contributor
Author
|
@Wires77 thanks, will make those changes shortly. |
…this was a holdover from development. Updated string formatting in ImportTabClass:ImportPassiveTreeAndJewels to use escapeGGGString instead of manual formatting. Signed-off-by: Andrew Devlin <devlin1991@googlemail.com>
…s to avoid spellchecker issue. Signed-off-by: Andrew Devlin <devlin1991@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Pathfinder ascendancy notable "Traveller's Wisdom" not supported due to no support for "Attribute Passive Skills can intead grant " mods.
Note: Close in feature set to #1665 but handles the mod more generically to support Custom Modifiers, Item Modifiers, and hopefully any changes to "Traveller's Wisdom" without need for code changes.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://poe.ninja/poe2/pob/1b282 (PoB exported build using this PR)
https://pastebin.com/SN87XLgJ (Raw character json with alternative nodes)
^^ Note: The exported build requires this PR to load without error but this PR can load older exported builds without issue.
Youtube video of feature, right click image below -> open link in new tab
https://www.youtube.com/watch?v=hMqeedr8juI
Before screenshot:
After screenshot: