Skip to content

Added support for remnant effect#1782

Open
greatnameincoming wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
greatnameincoming:remnant-effect
Open

Added support for remnant effect#1782
greatnameincoming wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
greatnameincoming:remnant-effect

Conversation

@greatnameincoming
Copy link

Description of the problem being solved:

Adds support for

  • Remnants have #% increased effect
  • Effect and duration of chayula flames on you is doubled (legacy mod). The duration part of this line is ignored.

This has been applied to work on:

  • Into the breach flames (from chayula monk)
  • Life remnants (from bloodmage)
  • Mana remnants

Only the purple breach flames are actually used in calculation, the others only show up in the Calcs tab.

Steps taken to verify a working solution:

  • Verified remnant effect correctly scales the values of the above skills in the Calcs tab
  • Verified the remnant effect modifier and breakdown is correct
  • Verified the chaos damage applied by purple chayula flames is correct

Link to a build that showcases this PR:

https://pobb.in/edDxyBDYCfyV

Before screenshot:

image

After screenshot:

image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant