Added Essences to Add Modifier option when crafting Two Handed Maces #1735
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Wonder if we should instead change the weapon type to "Two Hand Mace" as that is how it's shown on trade site for PoE2. PoE1 shows "Two Handed Mace". Not sure why it was changed, but would be nice to match in game. Same with swords and axes. Something to ask Local probably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1733
Description of the problem being solved:
The issue comes from different wording regarding the Two Handed Maces:
In
maces.luathe type is"Two Handed Mace", inessences.luait is"Two Hand Mace", but both files are automatically generated and cant be edited. So i added a bit of code inItemsTab.luato change type to"Two Hand Mace"to display the essences.