Skip to content

Move all ravendb specific ID generation out of the shared project#5649

Open
rbev wants to merge 2 commits into
masterfrom
rhys/move-raven-code
Open

Move all ravendb specific ID generation out of the shared project#5649
rbev wants to merge 2 commits into
masterfrom
rhys/move-raven-code

Conversation

@rbev

@rbev rbev commented Jul 24, 2026

Copy link
Copy Markdown
Contributor
  • Moved singleton document ids into their respective RavenDB repositories
  • Moved Collection name constants into the RavenDB repositories
  • Moved ID formatters into the RavenDB repositories
  • Removed some unused code

@rbev
rbev force-pushed the rhys/move-raven-code branch from 664ddb5 to 5c74e97 Compare July 24, 2026 05:40

@johnsimons johnsimons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.
I have added a few comments along the way.

Comment thread src/ServiceControl.Persistence.RavenDB/ErrorMessagesDataStore.cs
Comment thread src/ServiceControl.Persistence/Recoverability/ReclassifyErrorSettings.cs Outdated
Comment thread src/ServiceControl/Operations/ErrorIngestionFaultPolicy.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants