No mixed cancellation diagnostic on interfaceless handlers#388
Merged
DavidBoike merged 3 commits intomasterfrom Mar 11, 2026
Merged
No mixed cancellation diagnostic on interfaceless handlers#388DavidBoike merged 3 commits intomasterfrom
DavidBoike merged 3 commits intomasterfrom
Conversation
| } | ||
|
|
||
| if (tokens > 0 && contexts > 0) | ||
| if (tokens > 0 && contexts > 0 && !IsInterfacelessHandlerMethod(method)) |
Contributor
There was a problem hiding this comment.
Would it be worthwhile using GetTypeByMetadataName similar to HandlerKnownTypes here?
https://github.com/Particular/NServiceBus/pull/7641/changes#diff-f7194ec8cd12a446e48fb1a09b7c1a0f630d52660b4b9effa41c4ba73ed0d952L7 because that allows you to do symbol comparison https://github.com/Particular/NServiceBus/pull/7641/changes#diff-4d4688cc317573bf2091d251d5375261d47f3ef7426f6c7f09c2c4b5f0015227R56
Member
Author
There was a problem hiding this comment.
All of the Particular analyzers around cancellation and a CancellableContext use more of a "looks like" comparison, and don't reference NServiceBus types in the tests at all, so symbol comparison wouldn't work.
danielmarbach
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a method:
Then diagnostic PS0014 "Methods should not have both CancellationToken parameters and parameters implementing ICancellableContext" will not be raised.