Incomplete cache should not interfere with re-running#340
Merged
Conversation
…lso refactor _unique_id()
…d when cache is incomplete
erikvansebille
approved these changes
May 19, 2026
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Looks good! One small comment below
Comment on lines
+263
to
+264
| id_path = cache_dir / EXPEDITION_IDENTIFIER | ||
| last_expedition_path = cache_dir / EXPEDITION_LATEST |
Member
There was a problem hiding this comment.
is there a reason not to use joinpath here? That is more robust to backslashes-vs-forwardslashes confusion between linux and windows? That's relevant because we're not testing on Windows (or are we?)
Collaborator
Author
There was a problem hiding this comment.
We do test on Windows, so yes, good idea to go for more robustness, will do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the cache logic so that a subsequent run is not met with an error/instruction to manually delete
cachedirectory when a previous run was interrupted. This was an annoying feature previously. Now theid_latestwill be updated to the latest timestamp because a cache from an interrupted/incomplete run is not useful.Closes #304