Skip to content

expose the manifest-path parameter - #21

Merged
VeckoTheGecko merged 14 commits into
Parcels-code:mainfrom
keewis:manifest-path
Aug 4, 2026
Merged

expose the manifest-path parameter#21
VeckoTheGecko merged 14 commits into
Parcels-code:mainfrom
keewis:manifest-path

Conversation

@keewis

@keewis keewis commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Needed for pydata/xarray#11481. Closes #20.

@VeckoTheGecko VeckoTheGecko left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I missed this in my notifications. Thanks for the PR @keewis ! LGTM

@VeckoTheGecko
VeckoTheGecko enabled auto-merge (squash) August 3, 2026 00:50
@VeckoTheGecko
VeckoTheGecko disabled auto-merge August 3, 2026 00:51
@VeckoTheGecko

Copy link
Copy Markdown
Collaborator

Hmm . i have no idea why CI is failing here with a cache miss even though the cache is definitely defined?

@VeckoTheGecko

Copy link
Copy Markdown
Collaborator

Let me know if you have any ideas @keewis

Btw, the edits I pushed here were to ensure that manifest-path was an optional input.

I have given you push access here. Feel free to push edits and merge if you'd like

@keewis

keewis commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator Author

I think the problem is that the caches can't be deleted by tests run on a branch on my fork. Let me try clearing the caches manually.

@keewis

keewis commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator Author

well, looks like either pixi.lock and ./pixi.lock are treated differently, or we need special permissions to clear the caches in CI. Either way this works now, so you can go ahead and merge now (and if possible a release would also be nice)

@VeckoTheGecko
VeckoTheGecko merged commit ffbed15 into Parcels-code:main Aug 4, 2026
10 checks passed
@VeckoTheGecko VeckoTheGecko mentioned this pull request Aug 4, 2026
@VeckoTheGecko

Copy link
Copy Markdown
Collaborator

if possible a release would also be nice

Done! Thanks for the PR

@keewis
keewis deleted the manifest-path branch August 4, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support --manifest-path (or similar)

2 participants