Resolved bug in the selection of particle's default z value when it is not provided by the user - #2781
Merged
Merged
Conversation
2 tasks
erikvansebille
approved these changes
Aug 5, 2026
erikvansebille
left a comment
erikvansebille
left a comment
Member
There was a problem hiding this comment.
Code looks good! I pushed an update to the docstring. I'll merge now
erikvansebille
enabled auto-merge (squash)
August 5, 2026 06:07
erikvansebille
added a commit
to erikvansebille/Parcels
that referenced
this pull request
Aug 5, 2026
Now that Parcels-code#2781 is fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously the logic to initialize the depth level of particles when no depth was provided did not work as intended, and lead to the initialization of particles out of bounds. This fixes that by selected the depth level from the fields that is closest to zero.
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure