Skip to content

Add fesom tutorial to documentation#2640

Open
fluidnumericsJoe wants to merge 2 commits into
mainfrom
docs/tutorial_fesom
Open

Add fesom tutorial to documentation#2640
fluidnumericsJoe wants to merge 2 commits into
mainfrom
docs/tutorial_fesom

Conversation

@fluidnumericsJoe
Copy link
Copy Markdown
Contributor

Description

This tutorial uses the provided fesom2 channel data for demonstrating the basics of getting started with FESOM2 (unstructured grid) in parcels

Checklist

  • [ X ] Closes #xxxx
  • [ X ] This PR targets the correct branch (main for normal development, v3-support for v3 support)

This tutorial uses the provided fesom2 channel data for demonstrating
the basics of getting started with FESOM2 (unstructured grid) in parcels
Copy link
Copy Markdown
Member

@erikvansebille erikvansebille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; two small comments below

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I can't easily comment on specific lines, here two comments:

  1. In other tutorials, we always use ds = parcels.convert.fesom_to_ugrid(ds) (instead of ds = fesom_to_ugrid(ds)) to make explicit that these convert functions are part of parcels. Do that here too?
  2. Is there an easy/quick way to also plot the velocity field before the pset.execute()? In that way, users get a feel for what kind of flow to expect. And that's a nice help for them to visualise their own unstructured flow field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants