Add fesom tutorial to documentation#2640
Open
fluidnumericsJoe wants to merge 2 commits into
Open
Conversation
This tutorial uses the provided fesom2 channel data for demonstrating the basics of getting started with FESOM2 (unstructured grid) in parcels
for more information, see https://pre-commit.ci
Member
erikvansebille
left a comment
There was a problem hiding this comment.
Looks great; two small comments below
Member
There was a problem hiding this comment.
As I can't easily comment on specific lines, here two comments:
- In other tutorials, we always use
ds = parcels.convert.fesom_to_ugrid(ds)(instead ofds = fesom_to_ugrid(ds)) to make explicit that these convert functions are part of parcels. Do that here too? - Is there an easy/quick way to also plot the velocity field before the pset.execute()? In that way, users get a feel for what kind of flow to expect. And that's a nice help for them to visualise their own unstructured flow field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This tutorial uses the provided fesom2 channel data for demonstrating the basics of getting started with FESOM2 (unstructured grid) in parcels
Checklist
mainfor normal development,v3-supportfor v3 support)