Changing Argo float kernels to use boolean masking#2632
Draft
erikvansebille wants to merge 1 commit into
Draft
Conversation
Which is easier to read than the np.where() clauses used before Performance can be tested in the benchmarking suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the Kernels in the Argo tutorial to use boolean masking, which is easier to read than the
np.where()clauses used before.I'll create a script in the benchmarking repo so that we can test performance between the two types of vectorised
if-statements (see also #2197)Description
Checklist
np.where()versus boolean masking in Parcels kernels and interpolators #2197mainfor normal development,v3-supportfor v3 support)AI Disclosure