Rename sgrid.DimDimPadding to sgrid.FaceNodePadding#2557
Merged
VeckoTheGecko merged 2 commits intoParcels-code:mainfrom Mar 25, 2026
Merged
Rename sgrid.DimDimPadding to sgrid.FaceNodePadding#2557VeckoTheGecko merged 2 commits intoParcels-code:mainfrom
VeckoTheGecko merged 2 commits intoParcels-code:mainfrom
Conversation
VeckoTheGecko
commented
Mar 25, 2026
Comment on lines
318
to
329
| @dataclass | ||
| class DimDimPadding: | ||
| """A data class representing a dimension-dimension-padding triplet for SGrid metadata. | ||
| class FaceNodePadding: | ||
| """A data class representing a face-node-padding triplet for SGrid metadata. | ||
|
|
||
| This triplet can represent different relations depending on context within the standard | ||
| For example - for "face_dimensions" this can show the relation between an edge (dim1) and a node | ||
| (dim2). | ||
| In the context of a 2D grid, "face" corresponds with an edge. | ||
|
|
||
| Use the .to_diagram() method to visualize the representation. | ||
| """ | ||
|
|
||
| dim1: str | ||
| dim2: str | ||
| face: Dim | ||
| node: Dim | ||
| padding: Padding |
Contributor
Author
There was a problem hiding this comment.
The test suite for the sgrid parsing etc. is very thorough, so the main thing to review is this block.
erikvansebille
approved these changes
Mar 25, 2026
Member
erikvansebille
left a comment
erikvansebille
left a comment
There was a problem hiding this comment.
Very good change; I always found the DimDim naming a bit confusing. This makes it much clearer!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After doing the diagrams in #2553 , I thought that this naming was more expressive.
Closes None