Add SulfurCube#equipItem#14062
Open
Strokkur424 wants to merge 1 commit into
Open
Conversation
Contributor
|
If it isn't just a shortcut to editing the equipment I'm not sure I like it being called equipItem. Especially with the potential dropping of another item. I want some more thoughts on naming. I like Alternatives I thought of:
|
Member
|
Well its based in the nms method maybe just a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes the NMS-internal
SulfurCube#equipItemmethod as an API-method.Currently, if you want to set the item swallowed by a SulfurCube, you have to call the following code:
This is fine if you know about it. However that skips a little bit of logic that's inside the NMS
SulfurfCube#equipItemmethod. Additionally, it's not intuitive for anyone simply scrolling through the SulfurCube API methods.(Discussion: https://discord.com/channels/289587909051416579/925530366192779286/1526310872450994318)