Lazy initialization of formattedDisplayName#14039
Open
Dominilk01 wants to merge 1 commit into
Open
Conversation
Member
|
Is this fixing a bug or something? What exactly is the purpose of this rather than stopping the allocation of this? |
Contributor
Author
|
I made it cause for example in fastboard (a scoreboard libbrary that use nms packets with reflection) when you update title it create a new objective each time, so if you have an animated scoreboard it yust spend most of it time creating this Component |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective#getFormattedDisplayName()is only used internally by vanilla commands ScoreboardCommand and TriggerCommand.So its unnecessary to initialize with objective it if its if only a small part of Objective will ever use it.