Add API for nms Player.canCriticalAttack(Entity)#13915
Open
LeonTG wants to merge 2 commits into
Open
Conversation
Doc94
reviewed
May 26, 2026
| * @param entity target entity to check if can critical attack. | ||
| * @return Whether they can critical attack the target entity. | ||
| */ | ||
| public boolean canCriticalAttack(Entity entity); |
Member
There was a problem hiding this comment.
im not sure about the name also based in NMS this is not the full logic for consider its a critical (fullStrengthAttack in NMS) so maybe you can mention in the docs...
Author
There was a problem hiding this comment.
I can add the fullStrengthAttack logic too if you want?
it would defo make more sense in the way I use this API in my own project to also account for that
Member
There was a problem hiding this comment.
hmm i fell can be good expose that
Author
There was a problem hiding this comment.
not sure I know what you mean by that ngl xd
Co-authored-by: Pedro <3602279+Doc94@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also added this to my own Paper fork, and again figured it was nice API for others to use too