Improve old spawn egg legacy conversion #13532
Conversation
The code to convert legacy spawn eggs was a bit ridiculous, so I've improved it somewhat: * Instead of first setting maxData to 121 for LEGACY_MONSTER_EGG and then continue-ing every iteration of the loop (in other words, doing nothing for LEGACY_MONSTER_EGG), just continue the outer loop for LEGACY_MONSTER_EGG (in other words, do nothing for LEGACY_MONSTER_EGG) * Instead of going over all old spawn eggs inside the Material loop (so _for every single material_), just do it once at the end
|
should just get rid of Legacy Materials lol |
Imo we should just get rid of Material :p (I mean still including it, but replacing it with bytecode generated based on the item and block registries on the server) I'm one of the people still running the same server and world file as in the beta get-CraftBukkit-jars-from-Jenkins days and I still have some of the same outdated plugin JARs that I can't just remove, so I have a personal interest in keeping the conversions in place~ |
|
decompile and update those plugins lol |
There is already ItemType and BlockType that are meant to replace Material one day and are already used in newer apis |
Yep yep that's what I mean :) |
3 participants
The code to convert legacy spawn eggs was a bit ridiculous, so I've improved it somewhat:
LEGACY_MONSTER_EGGand then continue-ing every iteration of the loop (in other words, doing nothing forLEGACY_MONSTER_EGG), just continue the outer loop forLEGACY_MONSTER_EGG(in other words, do nothing forLEGACY_MONSTER_EGG)