workflows4: Fix workflow scripts and enhance prun options validation#86
Open
mightqxc wants to merge 16 commits into
Open
workflows4: Fix workflow scripts and enhance prun options validation#86mightqxc wants to merge 16 commits into
mightqxc wants to merge 16 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the native workflow tooling by adding an on-worker merge script, making the multistep_merge workflow template more self-contained (defaults + sandboxing the merge script), and expanding the workflow description schema to support secondary datasets, file-type filters, and containers.
Changes:
- Add and package
share/workflow_scripts/merge.shand update themultistep_mergetemplate to use it (including copying it into the sandbox). - Extend
WorkflowDescription/WorkflowStepto serialize/validate new step attributes:inDsType,secondaryDSs,secondaryDsTypes,containerImage, anduseAthenaPackages. - Adjust
pchain_nativestartup to restore Rucio-related import paths from the originalPYTHONPATH.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| share/workflow_scripts/merge.sh | New worker-node merge helper that consumes --writeInputToTxt output and runs hadd. |
| setup.py | Installs the new workflow script into etc/panda/share/workflow_scripts. |
| pandaclient/workflow_templates/multistep_merge.py | Adds defaults, script discovery/copy-to-sandbox behavior, and configurable output/input filenames. |
| pandaclient/workflow_description.py | Expands step schema + validation and updates documentation examples. |
| pandaclient/PChainScript_native.py | Restores selected paths from the original environment to support importing rucio. |
| packages/full/pyproject.toml | Ensures workflow scripts are included as shared wheel data. |
| examples/signal_background_combine_wfd.yaml | Adds a multi-branch workflow example using secondary datasets and type filters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.