[BugFix] fix all reduce fusion accurate issue#7923
Open
BingooYang wants to merge 1 commit into
Open
Conversation
|
Thanks for your contribution! |
CI报告基于以下代码生成(30分钟更新一次): 1 任务总览所有 required 任务已通过,建议通过;当前有 2 个 optional 任务失败、1 个 optional workflow 等待中,仅供参考,不阻塞合并。
2 任务状态汇总日志列说明:失败任务直接使用 CI 日志链接;optional 失败不阻塞合并,本次不做深度分析。 2.1 Required任务 : 10/10 通过
2.2 可选任务 — 28/31 通过
3 失败详情(仅 required)无 required 失败任务。 备注
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7923 +/- ##
==========================================
Coverage ? 63.80%
==========================================
Files ? 467
Lines ? 64969
Branches ? 9963
==========================================
Hits ? 41451
Misses ? 20713
Partials ? 2805
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
修复同时开启 export FD_USE_PHI_RMSNORM=1 和 --enable-flashinfer-allreduce-fusion 引起的精度问题
Modifications
开启 export FD_USE_PHI_RMSNORM=1 环境变量,RMSNorm其中一个分支适配 all reduce fusion
Usage or Command
NA
Accuracy Tests
done
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.