Open
Conversation
|
Thanks for your contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7102 +/- ##
==========================================
Coverage ? 73.93%
==========================================
Files ? 402
Lines ? 56576
Branches ? 8942
==========================================
Hits ? 41831
Misses ? 11810
Partials ? 2935
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: [Engine][DataProcessor] Simplify force decode logic in _decode_token and add unit tests
Body:
Motivation
When streaming ends with undecoded tokens (e.g., partial UTF-8 byte-level tokens),
_decode_tokenneeds to return these remaining token IDs. The original force decodelogic used a two-level lookup with
prefix_offset,prev_cum_len, andstart_idx,which was unnecessarily complex —
cum_tokens[read_offset:]is sufficient to captureall unreturned tokens in every case.
Modifications
engine/common_engine.py: Simplified the force decode path in_decode_token.Replaced the two-level remaining token lookup (
cum_tokens[start_idx:read_offset]with fallback to
cum_tokens[read_offset:]) with a singlecum_tokens[read_offset:].test_decode_token.py: Added unit tests for_decode_tokencovering:is_end=True)Usage or Command