Open
Conversation
|
Thanks for your contribution! |
Contributor
There was a problem hiding this comment.
Pull request overview
该 PR 旨在修复/重构 OpenAI entrypoint 下 Ernie 工具调用(tool_call)解析逻辑,重点调整 ernie-x1 的非流式与流式解析实现,并同步改动了 ernie-45-vl-thinking 的流式处理细节。
Changes:
- 重写
ErnieX1ToolParser.extract_tool_calls():改为基于正则提取并直接json.loads。 - 重写
ErnieX1ToolParser.extract_tool_calls_streaming():调整流式解析与增量输出逻辑、日志接口。 - 移除
ernie-x1的单测文件;并在ernie_45_vl_thinking流式解析中删除“空 chunk 跳过”逻辑。
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
tests/entrypoints/openai/tool_parsers/test_ernie_x1_tool_parser.py |
删除了 Ernie X1 tool parser 的单元测试覆盖。 |
fastdeploy/entrypoints/openai/tool_parsers/ernie_x1_tool_parser.py |
大幅改动非流式/流式 tool_call 解析实现与返回结构。 |
fastdeploy/entrypoints/openai/tool_parsers/ernie_45_vl_thinking_tool_parser.py |
流式解析逻辑中不再跳过空 delta chunk。 |
fastdeploy/entrypoints/openai/tool_parsers/ernie_x1_tool_parser.py
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7079 +/- ##
==========================================
Coverage ? 73.15%
==========================================
Files ? 402
Lines ? 56421
Branches ? 8894
==========================================
Hits ? 41273
Misses ? 12250
Partials ? 2898
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
修复tool_parser中过滤\n或者空格的问题
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.