[Other] support video_fps args for video bench#7077
[Other] support video_fps args for video bench#7077Wanglongzhi2001 wants to merge 1 commit intoPaddlePaddle:developfrom
Conversation
|
Thanks for your contribution! |
| # NOTE(Wanglongzhi2001): temporary parameter for video understanding benchmark | ||
| video_fps: Optional[float] = None | ||
|
|
There was a problem hiding this comment.
这里新增的 video_fps 目前只会被透传进 to_dict_for_infer() 的 req_dict,但在仓库内的输入处理链路中未找到任何地方读取/应用该字段(搜索仅在 protocol.py 中出现)。这会导致基准测试传入 video_fps 也不会影响实际抽帧逻辑。建议在预处理阶段将其映射到视频 item 的 fps(如 messages/multimodal_data 的 video part),或改为复用现有的 mm_processor_kwargs.video_fps 机制并在处理器侧消费该参数。
| # NOTE(Wanglongzhi2001): temporary parameter for video understanding benchmark | ||
| video_fps: Optional[float] = None | ||
|
|
There was a problem hiding this comment.
新增请求字段后建议补充单测覆盖:例如验证当用户传入 video_fps 时,CompletionRequest/ChatCompletionRequest.to_dict_for_infer() 的输出会包含该字段(且为预期类型/取值)。仓库已有 openai protocol 相关测试(tests/entrypoints/openai/*),增加回归测试能避免后续重构导致该临时参数被悄然丢弃。
| # NOTE(Wanglongzhi2001): temporary parameter for video understanding benchmark | ||
| video_fps: Optional[float] = None |
There was a problem hiding this comment.
当前 PR 标题使用了 [Other],但仓库 PR 模板的 tag list 中是 [Others](见 .github/pull_request_template.md 的 Checklist)。建议把标题 tag 调整为已有的 [Others] 或新增语义更明确的 tag,以满足仓库约定。
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7077 +/- ##
==========================================
Coverage ? 74.07%
==========================================
Files ? 401
Lines ? 56575
Branches ? 8942
==========================================
Hits ? 41909
Misses ? 11685
Partials ? 2981
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Motivation
Modifications
Usage or Command
Accuracy Tests
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.