feat: added the new datasets - #1249
Open
chakravarthik27 wants to merge 7 commits into
Open
Conversation
chakravarthik27
commented
Aug 3, 2026
chakravarthik27
commented
Collaborator
- HeadQA
- MedExQA
…Predefined Datasets
feature/implement the medexqa
…dataset feat: implement HeadQA
blidiselalin
left a comment
blidiselalin
left a comment
There was a problem hiding this comment.
Are unit tests not needed for this 2 new evaluations?
|
|
||
| print(f"Successfully downloaded and extracted to {extract_to}") | ||
|
|
||
| except requests.exceptions.RequestException as e: |
There was a problem hiding this comment.
Fix ensure_download_and_unzip error handling -> Exceptions are caught and only printed; the function returns None and callers proceed as if the download succeeded. If the directory exists but is incomplete or corrupted from a previous interrupted run, the code silently reuses it.
|
|
||
| else: | ||
| # 2. Download the file (Removed stream=True since response.content reads all at once) | ||
| response = requests.get(url) |
There was a problem hiding this comment.
Add timeouts, retries, and validation to the network download
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.