fix(auth): remove AuthGuard subscription leak on every route activati…#347
fix(auth): remove AuthGuard subscription leak on every route activati…#347Piyush0000 wants to merge 1 commit into
Conversation
…on (PSMRI#138) AuthGuard.canActivate() subscribed to HttpServiceService.currentLangugae$ on every invocation and stored the emitted value in current_language_set. currentLangugae$ is exposed as `BehaviorSubject(...).asObservable()` and never completes, so each protected route activation appended a fresh subscriber that was never released. Since AuthGuard is a singleton @Injectable used by canActivate on seven protected routes (service, servicePoint, registrar, nurse-doctor, lab, pharmacist, datasync), repeated navigation accumulated subscribers indefinitely. current_language_set was assigned inside the subscribe callback but never read anywhere in the guard, in templates, or by reflective access from sibling code. The subscription served no purpose; the correct fix is to delete it rather than convert it to take(1) or takeUntilDestroyed — there is no consumer to feed. Changes: * auth-guard.service.ts: remove the dead `current_language_set` field, the dead currentLangugae$ subscription, the HttpServiceService dependency injection, and the now-unused import. Guard logic reduces to the session-key validation pipeline it always relied on. * auth-guard.service.spec.ts: new spec that locks in the no-leak contract — verifies the guard no longer holds a reference to HttpServiceService or `current_language_set`, that 20 sequential canActivate calls do not regrow the field, and that the existing navigation semantics (route to /login on invalid session, no-op on valid session) are preserved.
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
AuthGuard.canActivate() subscribed to HttpServiceService.currentLangugae$ on every invocation and stored the emitted value in current_language_set. currentLangugae$ is exposed as
BehaviorSubject(...).asObservable()and never completes, so each protected route activation appended a fresh subscriber that was never released. Since AuthGuard is a singleton @Injectable used by canActivate on seven protected routes (service, servicePoint, registrar, nurse-doctor, lab, pharmacist, datasync), repeated navigation accumulated subscribers indefinitely.current_language_set was assigned inside the subscribe callback but never read anywhere in the guard, in templates, or by reflective access from sibling code. The subscription served no purpose; the correct fix is to delete it rather than convert it to take(1) or takeUntilDestroyed — there is no consumer to feed.
Changes:
auth-guard.service.ts: remove the dead
current_language_setfield, the dead currentLangugae$ subscription, the HttpServiceService dependency injection, and the now-unused import. Guard logic reduces to the session-key validation pipeline it always relied on.auth-guard.service.spec.ts: new spec that locks in the no-leak contract — verifies the guard no longer holds a reference to HttpServiceService or
current_language_set, that 20 sequential canActivate calls do not regrow the field, and that the existing navigation semantics (route to /login on invalid session, no-op on valid session) are preserved.📋 Description
JIRA ID:
Please provide a summary of the change and the motivation behind it. Include relevant context and details.
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.