fix(error-handler): use console.error and remove re-throw to prevent zone error loop

[tarun-227]

Summary

Two bugs in src/app/app-modules/core/services/global-error-handler.service.ts.

---

Bug 1 — Wrong log level: console.log instead of console.error

// Before
console.log(error);

// After
console.error(error);

GlobalErrorHandler is Angular's last-resort error sink. Using console.log means errors are indistinguishable from informational messages and are invisible in browser DevTools when the "Errors" filter is active. console.error correctly marks the entry as an error, triggers the red badge in DevTools, and is picked up by external monitoring tools (Sentry, Datadog, etc.).

---

Bug 2 — Re-throwing inside ErrorHandler.handleError causes an infinite loop

// Before
handleError(error: Error) {
  console.log(error);
  throw error;      // ← re-enters NgZone error handling → calls handleError again
}

// After
handleError(error: Error) {
  console.error(error);
  // No re-throw: ErrorHandler is the terminal handler; re-throwing loops back
  // into Angular's zone which invokes handleError a second time, eventually
  // freezing the application with a call-stack overflow.
}

Angular's ErrorHandler.handleError is called by NgZone when an unhandled error escapes. Re-throwing inside the handler causes NgZone to catch the error again and call handleError recursively, which can freeze the UI.

Summary by CodeRabbit

• Bug Fixes
  • Enhanced error logging and improved global error handling to prevent uncontrolled error propagation, resulting in more stable application operation.

[coderabbitai]

📝 Walkthrough

Walkthrough

The global error handler service method is updated to log errors via console.error instead of console.log and removes the re-throw behavior, preventing error propagation after logging.

Changes

Error Handler Logging Update

Layer / File(s)	Summary
Error Logging Behavior src/app/app-modules/core/services/global-error-handler.service.ts	GlobalErrorHandler.handleError switches from console.log to console.error for error output and removes the throw error statement, preventing upstream error propagation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A humble handler, once it threw,
Now whispers errors true and true,
With console.error, loud and clear,
No re-throws to cause us fear! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes: switching to console.error and removing the re-throw that causes the zone error loop.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 60 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

🧹 Nitpick comments (1)

src/app/app-modules/core/services/global-error-handler.service.ts (1)

27-34: Consider hooking an APM/monitoring sink alongside console.error.

console.error is sufficient for DevTools visibility, but console output is ephemeral in production. If this application already integrates an APM tool (e.g., Sentry, Datadog RUM, Azure Application Insights), the handleError method is the canonical place to forward unhandled errors to that sink before (or instead of) the console.error call — without re-throwing.

// Example (Sentry):
handleError(error: Error): void {
  console.error(error);
  // Sentry.captureException(error); // forward to APM
}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/app/app-modules/core/services/global-error-handler.service.ts` around
lines 27 - 34, Augment the handleError method in global-error-handler.service.ts
to forward unhandled errors to the app's APM/monitoring sink in addition to
console.error: locate the handleError(error: Error) implementation, keep the
existing console.error(error) for DevTools, and add a call to your monitoring
client (e.g., Sentry.captureException(error) or an injected
MonitoringService.reportError(error)) so errors are sent to your APM; if using
dependency injection, inject the monitoring client into the service and call its
capture/report method inside handleError.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/app/app-modules/core/services/global-error-handler.service.ts`:
- Around line 27-34: Augment the handleError method in
global-error-handler.service.ts to forward unhandled errors to the app's
APM/monitoring sink in addition to console.error: locate the handleError(error:
Error) implementation, keep the existing console.error(error) for DevTools, and
add a call to your monitoring client (e.g., Sentry.captureException(error) or an
injected MonitoringService.reportError(error)) so errors are sent to your APM;
if using dependency injection, inject the monitoring client into the service and
call its capture/report method inside handleError.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: adb68b6d-4119-4081-9f0f-8426094b34ca

📥 Commits

Reviewing files that changed from the base of the PR and between 22509ad and 9f4583e.

📒 Files selected for processing (1)

• src/app/app-modules/core/services/global-error-handler.service.ts