-
Notifications
You must be signed in to change notification settings - Fork 32
Implement Commit Message Linting and Automation for Inventory. #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sahil1694
wants to merge
8
commits into
PSMRI:develop
Choose a base branch
from
Sahil1694:feature/commit-linting-setup
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b8c3696
docs(readme): update README with test line
Sahil1694 1cf6fe7
chore: remove unnecessary files
Sahil1694 fc24543
Remove node_modules from repository
Sahil1694 164ce5a
fix: adding rules for commitlint
Sahil1694 40eeb3d
fix: fixing lint-commits.yml
Sahil1694 da158af
Update application.properties
Sahil1694 ec84a61
Update commit-msg
Sahil1694 3eef052
Update package.json
Sahil1694 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: Commit Compliance | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
| branches: [main, develop] | ||
|
|
||
| jobs: | ||
| commitlint: | ||
| name: Lint commit messages | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event.pull_request.head.ref }} | ||
| repository: ${{ github.event.pull_request.head.repo.full_name }} | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 18 | ||
| cache: 'npm' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci --legacy-peer-deps | ||
|
|
||
| - name: Validate commits | ||
| run: npx commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} --verbose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,9 @@ dist/ | |
| nbdist/ | ||
| .nb-gradle/ | ||
|
|
||
| #Node modules | ||
| node_modules/ | ||
|
|
||
| #Config | ||
| config.service.ts | ||
| config.json | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| npx --no -- commitlint --edit "$1" | ||
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| module.exports = { | ||
| extends: ["@commitlint/config-conventional"], | ||
| rules: { | ||
| "body-leading-blank": [1, "always"], | ||
| "body-max-line-length": [2, "always", 100], | ||
| "footer-leading-blank": [1, "always"], | ||
| "footer-max-line-length": [2, "always", 100], | ||
| "header-max-length": [2, "always", 100], | ||
| "subject-case": [ | ||
| 2, | ||
| "never", | ||
| ["sentence-case", "start-case", "pascal-case", "upper-case"], | ||
| ], | ||
| "subject-empty": [2, "never"], | ||
| "subject-full-stop": [2, "never", "."], | ||
| "type-case": [2, "always", "lower-case"], | ||
| "type-empty": [2, "never"], | ||
| "type-enum": [ | ||
| 2, | ||
| "always", | ||
| [ | ||
| "build", | ||
| "chore", | ||
| "ci", | ||
| "docs", | ||
| "feat", | ||
| "fix", | ||
| "perf", | ||
| "refactor", | ||
| "revert", | ||
| "style", | ||
| "test", | ||
| ], | ||
| ], | ||
| }, | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.