Skip to content

AMM-1603 Edit Indent Request changes#80

Merged
helenKaryamsetty merged 14 commits intoPSMRI:developfrom
devikasuresh20:develop
Jun 25, 2025
Merged

AMM-1603 Edit Indent Request changes#80
helenKaryamsetty merged 14 commits intoPSMRI:developfrom
devikasuresh20:develop

Conversation

@devikasuresh20
Copy link
Copy Markdown
Contributor

@devikasuresh20 devikasuresh20 commented Jun 25, 2025

📋 Description

JIRA ID: AMM-1603

Added code changes for enabling update button in edit indent request screen.


✅ Type of Change

  • 🐞 Bug fix (non-breaking change which resolves an issue)
  • New feature (non-breaking change which adds functionality)
  • 🔥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🛠 Refactor (change that is neither a fix nor a new feature)
  • ⚙️ Config change (configuration file or build script updates)
  • 📚 Documentation (updates to docs or readme)
  • 🧪 Tests (adding new or updating existing tests)
  • 🎨 UI/UX (changes that affect the user interface)
  • 🚀 Performance (improves performance)
  • 🧹 Chore (miscellaneous changes that don't modify src or test files)

ℹ️ Additional Information

Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.

Summary by CodeRabbit

  • Refactor

    • Improved template attribute formatting and class usage for better code clarity and consistency in the indent request form.
    • Updated conditional logic to enhance accuracy when determining edit mode in the indent request workflow.
  • Chores

    • Updated API endpoint URLs in environment configurations to new path formats.
    • Updated subproject reference for Common-UI.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jun 25, 2025

Walkthrough

This update modifies the commit reference for the Common-UI subproject, updates API endpoint paths in environment configuration files, refines Angular template attribute usage for clarity, and adjusts a conditional check in a TypeScript component to use a logical AND instead of OR. No public interfaces are changed.

Changes

Files/Group Change Summary
Common-UI (subproject reference) Updated commit reference from 3ec7e81443c830c7784bb39ad1fe34af1a939858 to bb57ecfac052a50bd85dc30eba1ca93335c34344.
src/environments/environment.prod.ts, src/environments/environment.test.ts Changed API endpoint path segments to new hyphenated forms without version numbers for COMMON_API_OPEN, COMMON_API, INVENTORY_API, MMU_API, and FHIR_API.
src/app/app-modules/inventory/indent/indent-order-worklist/.../indent-request/indent-request.component.html Simplified Angular template attribute syntax, reordered classes and directives, and clarified button logic without changing behavior.
src/app/app-modules/inventory/indent/indent-order-worklist/.../indent-request/indent-request.component.ts Changed conditional check in methodForIndentEdit from logical OR (`

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant IndentRequestComponent
    participant API

    User->>IndentRequestComponent: Initiates indent edit
    IndentRequestComponent->>IndentRequestComponent: methodForIndentEdit()
    alt viewItemReqObj is defined and not null
        IndentRequestComponent->>IndentRequestComponent: set editMode = true
        IndentRequestComponent->>IndentRequestComponent: getItemList()
    else
        IndentRequestComponent->>IndentRequestComponent: set editMode = false
    end
Loading

Possibly related PRs

  • AMM-1563 #72: Also updates the Common-UI subproject commit reference, directly related by submodule pointer changes.
  • commit ui commit changes #75: Advances the Common-UI subproject reference, continuing the same type of update as this PR.

Suggested reviewers

  • helenKaryamsetty

Poem

In the garden where APIs grow,
Paths are trimmed, old versions go.
Buttons align in tidy rows,
Logic checked so truth now shows.
A bunny hops with code so neat—
Hyphens, checks, and UI sweet!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between efd67a7 and 5cd50b8.

📒 Files selected for processing (1)
  • Common-UI (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Common-UI
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link
Copy Markdown

@helenKaryamsetty helenKaryamsetty merged commit 6dbadbf into PSMRI:develop Jun 25, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants