Skip to content

fix(linting): fixed linting to now handle for XML and JAVA #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zapper9982 wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

fix(linting): fixed linting to now handle for XML and JAVA #73

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dbba6ee
fix(linting): fixed linting to now handle for XML and JAVA
Zapper9982 Apr 25, 2025
cb86a77
fix(linting): fix according to coderabbit
Zapper9982 Apr 25, 2025
7092b06
fix(lint): fix according to coderabbit
Zapper9982 Apr 25, 2025
2bdee6e
fix(lint):Updated code according to coderabbit
Zapper9982 Apr 25, 2025
bead703
fix(lint): fixing compliance fail
Zapper9982 Apr 25, 2025
3d3aa9e
fix(rem): removed linting for java from package.json
Zapper9982 May 1, 2025
ee6fc7a
style(check): uncommiting the space
Zapper9982 May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added checkstyle.jar
View file
Open in desktop
Copy link
Copy Markdown
Member

@drtechie drtechie May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zapper9982 let's not commit binary files.

Binary file not shown.
10 changes: 8 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,15 @@
}
},
"lint-staged": {
"src/**/*.{ts,css,html}": [
"src/**/*.{ts,js}": [
"eslint --fix"
]
],
"**/*.java": [
"java -jar checkstyle.jar -c checkstyle.xml "
],
"**/*.xml": [
"xmllint --noout "
]
},
"devDependencies": {
"@commitlint/cli": "^19.8.0",
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/wipro/fhir/controller/generateresource/ResourceRequestGateway.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
* You should have received a copy of the GNU General Public License
* along with this program. If not, see https://www.gnu.org/licenses/.
*/
package com.wipro.fhir.controller.generateresource;
package com.wipro.fhir.controller.generateresource;
Copy link
Copy Markdown
Member

@drtechie drtechie May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zapper9982 what is this change about?

Copy link
Copy Markdown
Contributor Author

@Zapper9982 Zapper9982 May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I was just checking if the linting was working Java files. I guess I forgot to uncommit that change , lemme fix it


import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand Down
Loading