-
Notifications
You must be signed in to change notification settings - Fork 17
Release 3.6.1 #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release 3.6.1 #44
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0ada544
fix: amm-1990, 1985, 1972, 1982, 1989, 1983, 1987,1986
5Amogh f453693
remove langauge input which the components were not expecting
5Amogh 20a21fc
fix: elastic search changes
snehar-nd ef7fa1a
fix: handled placeholder value
snehar-nd 09f4202
fix: removed unwanted logs
snehar-nd fb6b49b
fix: 2038 integrated elastic search and advance es
snehar-nd 063e6e3
fix: optimised the search api code
snehar-nd e14c76d
Amm 1811 (#34)
helenKaryamsetty f2aceff
Merge pull request #33 from PSMRI/sn/ES
snehar-nd abfa309
fix: beneficiaryID column name was hiding
snehar-nd 9aa434e
Merge pull request #35 from PSMRI/sn/ES
snehar-nd f439a1b
fix: AMM-2038 found ben id issue , and age issue fixed that
snehar-nd 495ccc8
fix: removed the esenable condition for table serach
snehar-nd 9f81021
Revert "Amm 1811 (#34)"
5Amogh c4d3d49
Merge pull request #37 from PSMRI/temp-3.6.1/non-abdm-changes
5Amogh 55057d0
Merge branch 'release-3.6.1' of https://github.com/PSMRI/Common-UI inβ¦
snehar-nd c7748e6
Merge pull request #36 from PSMRI/sn/ES
snehar-nd 900d5a3
fix: amm-2038 es addidn space for serch
snehar-nd bc6c63e
Merge pull request #38 from PSMRI/sn/ES
5Amogh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: race condition β
this.beneficiary.benImage = ...can dereferenceundefined.Previously the image fetch was chained off the search response, so
this.beneficiarywas guaranteed populated beforethis.beneficiary.benImagewas assigned. After this refactor,fetchBeneficiaryImage(benFlowID)(Line 156) runs in parallel with the search (Line 150). Two problems:this.beneficiaryis stillundefined, and Line 221 (this.beneficiary.benImage = data.benImage;) throws aTypeError.this.beneficiaryis only set on the "single match" path (Line 197). On "not found" and "multiple matches" (Lines 180 and 189),this.beneficiarystaysundefined, so if the image call succeeds it still crashes.Either sequence the image fetch off the search result, or guard the assignment.
π‘οΈ Proposed fix (guarded assignment + sequence)
And harden the setter as a belt-and-braces:
next: (data: any) => { - if (data?.benImage) { + if (data?.benImage && this.beneficiary) { this.beneficiary.benImage = data.benImage; } },π Committable suggestion
π€ Prompt for AI Agents