Skip to content

Log bigquery lag #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cavis merged 1 commit into from
Jan 16, 2026
Merged

Log bigquery lag #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion index-bigquery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ export const handler = async (event) => {
const impRows = imps.map((r, i) => formatImpression(r, i));
const impCount = await bigquery.insert({ client, table: "dt_impressions", rows: impRows });

const info2 = { records: records.length, downloads: downCount, impressions: impCount };
const times = downRows.concat(impRows).map((r) => new Date(r.json.timestamp).getTime());
const lag = times.length ? Date.now() - Math.min(...times) : undefined;

const info2 = { records: records.length, downloads: downCount, impressions: impCount, lag };
log.info("Finished BigQuery", info2);
};

Expand Down
9 changes: 8 additions & 1 deletion index-bigquery.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,14 @@ describe("index-bigquery", () => {
expect(log.info.mock.calls[0][0]).toEqual("Starting BigQuery");
expect(log.info.mock.calls[0][1]).toEqual({ records: 7, downloads: 1, impressions: 4 });
expect(log.info.mock.calls[1][0]).toEqual("Finished BigQuery");
expect(log.info.mock.calls[1][1]).toEqual({ records: 7, downloads: 1, impressions: 4 });
expect(log.info.mock.calls[1][1].records).toEqual(7);
expect(log.info.mock.calls[1][1].downloads).toEqual(1);
expect(log.info.mock.calls[1][1].impressions).toEqual(4);

// test record timestamps are on 2017-02-21
const lagDate = new Date(Date.now() - log.info.mock.calls[1][1].lag);
expect(lagDate.getTime()).toBeGreaterThan(new Date("2017-02-21").getTime());
expect(lagDate.getTime()).toBeLessThan(new Date("2017-02-22").getTime());

expect(inserts[0].length).toEqual(1);
expect(inserts[0][0].insertId).toEqual("listener-episode-1/1487703699000");
Expand Down