Make ActiveRecord version check stricter to ensure Rails 8.1 compatibility#217
Closed
vrodokanakis wants to merge 2 commits intoPNixx:masterfrom
Closed
Make ActiveRecord version check stricter to ensure Rails 8.1 compatibility#217vrodokanakis wants to merge 2 commits intoPNixx:masterfrom
vrodokanakis wants to merge 2 commits intoPNixx:masterfrom
Conversation
Author
|
It seems that CI is failing due to Rails 8.1 changes in This means that schema creation doesn't work due to this. How would you like @PNixx to approach this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes compatibility with Rails 8.1. Right now, master branch doesn't work with Rails 8.1 due to underlying changes in ActiveRecord.
In ActiveRecord 8.1, due to this MR, method build_arel in
lib/active_record/relation/query_methods.rbnow accepts again only onealiasesargument.The change introduces a more precise version check, in order to no pass two arguments in super when we are using Rails 8.1+.