You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR extracts the repetitive hash calculation logic into a separate calculateHash function. The original hash calculation logic was duplicated in multiple places, and by extracting it, we improved code reusability and maintainability.
Changes:
Created the calculateHash function to compute the SHA-256 hash of a given input.
Replaced the duplicated hash calculation logic with calls to the new calculateHash function.
Impact:
Improved code maintainability by reducing redundancy.
The existing functionality remains unchanged, and the hash calculation logic is consistent.
Code Changes:
import { createHash } from 'crypto'
/**
* Calculates the SHA-256 hash of the given data
*
* @param {any} data - The data to hash, can be of any type.
* @returns {string} The resulting hash value (hexadecimal string)
*/
function calculateHash(data: any): string {
return createHash('sha256').update(JSON.stringify(data)).digest('hex')
}
const main = async function () {
// Other code
// Use the new calculateHash function
const ipHash = calculateHash(ipMetadata)
const nftHash = calculateHash(nftMetadata)
// Other code
}
Notes:
This change does not affect the functionality of the code, and the logic remains the same.
The hash calculation logic is now more concise and reusable.
This is the optimized version of the #calculateHash function.
import { createHash } from 'crypto';
/**
Calculates the SHA-256 hash of the given data
@param {any} data - The data to hash, can be of any type.
@returns {string} The resulting hash value (hexadecimal string)
*/
function calculateHash(data: any): string {
// Check for null or undefined data
if (data === null || data === undefined) {
throw new Error('Invalid data: data cannot be null or undefined');
}
// Handle cases where data cannot be serialized to JSON
let jsonData: string;
try {
jsonData = JSON.stringify(data);
} catch (error) {
throw new Error('Invalid data: data cannot be converted to JSON string');
}
// Return the SHA-256 hash value
return createHash('sha256').update(jsonData).digest('hex');
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR extracts the repetitive hash calculation logic into a separate
calculateHashfunction. The original hash calculation logic was duplicated in multiple places, and by extracting it, we improved code reusability and maintainability.Changes:
Created the
calculateHashfunction to compute the SHA-256 hash of a given input.Replaced the duplicated hash calculation logic with calls to the new
calculateHashfunction.Impact:
Improved code maintainability by reducing redundancy.
The existing functionality remains unchanged, and the hash calculation logic is consistent.
Code Changes:
Notes:
This change does not affect the functionality of the code, and the logic remains the same.
The hash calculation logic is now more concise and reusable.