Skip to content

Remove parameter mapping from v2.Problem#419

Merged
dweindl merged 1 commit intoPEtab-dev:mainfrom
dweindl:noparmap
Jul 29, 2025
Merged

Remove parameter mapping from v2.Problem#419
dweindl merged 1 commit intoPEtab-dev:mainfrom
dweindl:noparmap

Conversation

@dweindl
Copy link
Copy Markdown
Member

@dweindl dweindl commented Jul 24, 2025

Leftover from v1. Never worked. Not planned to implement.

Leftover from v1. Never worked. Not planned to implement.
@dweindl dweindl self-assigned this Jul 24, 2025
@dweindl dweindl marked this pull request as ready for review July 24, 2025 14:33
@dweindl dweindl requested a review from a team as a code owner July 24, 2025 14:33
@m-philipps
Copy link
Copy Markdown
Collaborator

Are you saying it never worked in v1 either?

@dweindl
Copy link
Copy Markdown
Member Author

dweindl commented Jul 28, 2025

Are you saying it never worked in v1 either?

No. It worked in v1. In v2 it's only copy-pasta from v1 that never worked for v2.

Copy link
Copy Markdown
Collaborator

@m-philipps m-philipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@dweindl dweindl merged commit 8977adb into PEtab-dev:main Jul 29, 2025
7 checks passed
@dweindl dweindl deleted the noparmap branch July 29, 2025 04:57
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.98%. Comparing base (d140230) to head (8cb07ee).
⚠️ Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
- Coverage   74.00%   73.98%   -0.03%     
==========================================
  Files          61       61              
  Lines        6764     6762       -2     
  Branches     1197     1197              
==========================================
- Hits         5006     5003       -3     
+ Misses       1297     1296       -1     
- Partials      461      463       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants