v2: Basic support for multiple models#418
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
- Coverage 74.40% 74.39% -0.01%
==========================================
Files 61 61
Lines 6692 6691 -1
Branches 1182 1181 -1
==========================================
- Hits 4979 4978 -1
- Misses 1256 1257 +1
+ Partials 457 456 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
m-philipps
left a comment
There was a problem hiding this comment.
Thank you, nothing important to add from my side.
| ) | ||
|
|
||
| @model.setter | ||
| def model(self, value: Model): |
There was a problem hiding this comment.
Perhaps change the name to make it clear that this modifies the Problem, e.g. set_model?
There was a problem hiding this comment.
model is a property. This function here is usually invoked via problem.model = some_model, it cannot be invoked as problem.model(some_model). I think the assignment should make it clear that this modifies the object.
Related to PEtab-dev#392. * Let v2.Problem have a list of models * Support constructing v2.Problem from files with multiple models * Move some validators to Annotated * Add some TODOs.
96e40eb to
250d87c
Compare
Related to #392.